Bug in PersistentMap equals implementation #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… this case we still need to do a promotion if needed
DmitryNekrasov
changed the title
…n case of partial collision` test
fzhinkin
requested changes
Apr 29, 2025
There was a problem hiding this comment.
One of the causes of all these problems is that some time ago the decision was made to abstain from canonicalizing the map builder due to an issue with iteration (#73).
Could you please check if there are any other problems left after that and if there are parts that could be simplified now?
|
I have fixed iteration issue in #217 and wrote tests to check it, so now I am completely confident in the correctness of how iterators work while maintaining the tree invariant. |
fzhinkin
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of repeated mutable key removal in
mutableReplaceNode, the same node may be passed astargetNodeandnewNode(due to the owner match in themutableCollisionRemoveEntryAtIndexmethod). However, if this node contains only one value and is not the root, we need to promote it to the top. This check and promotion happen in theupdateNodeAtIndexmethod, so even if the references are equal, this method must be called. However, if promotion is not needed, no extra allocation will be performed, since the nodes have the sameowner.