Skip to content

fix: validation bypass when updating block #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −9
Open

fix: validation bypass when updating block #958

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e30f5ea
fix: validation bypass when updating block
IkbelTalebHssan Apr 24, 2025
70eb1f1
fix: cropped settings fields
IkbelTalebHssan Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/public/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@
"image_error": "Image not found",
"file_error": "File not found",
"audio_error": "Audio not found",
"video_error": "Video not found"
"video_error": "Video not found",
"missing_fields_error": "Please make sure that all required fields are filled"
},
"menu": {
"terms": "Terms of Use",
Expand Down
3 changes: 2 additions & 1 deletion frontend/public/locales/fr/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@
"image_error": "Image introuvable",
"file_error": "Fichier introuvable",
"audio_error": "Audio introuvable",
"video_error": "Vidéo introuvable"
"video_error": "Vidéo introuvable",
"missing_fields_error": "Veuillez vous assurer que tous les champs sont remplis correctement"
},
"menu": {
"terms": "Conditions d'utilisation",
Expand Down
19 changes: 12 additions & 7 deletions frontend/src/app-components/tabs/TabPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright © 2024 Hexastack. All rights reserved.
* Copyright © 2025 Hexastack. All rights reserved.
*
* Licensed under the GNU Affero General Public License v3.0 (AGPLv3) with the following additional terms:
* 1. The name "Hexabot" is a trademark of Hexastack. You may not use this name in derivative works without express written permission.
Expand All @@ -24,16 +24,21 @@ export function TabPanel(props: TabPanelProps & GridProps) {
item
xs
role="tabpanel"
hidden={value !== index}
id={`vertical-tabpanel-${index}`}
aria-labelledby={`vertical-tab-${index}`}
sx={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is causing settings to become cropped in UI rendering.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @MohamedAliBouhaouala true I'll fix this 🙏

display: "block",
visibility: value === index ? "visible" : "hidden",
height: value === index ? "auto" : 0,
overflow: "hidden",
position: value === index ? "relative" : "absolute",
...sx,
}}
{...other}
>
{value === index ? (
<Grid container sx={{ flexDirection: "column", ...sx }}>
{children}
</Grid>
) : null}
<Grid container sx={{ flexDirection: "column" }}>
{children}
</Grid>
</Grid>
);
}
Expand Down
8 changes: 7 additions & 1 deletion frontend/src/components/visual-editor/BlockEditForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ export const BlockEditForm: FC<ComponentFormProps<IBlock>> = ({
updateBlock({ id: block.id, params });
}
};
const onSubmitError = () => {
toast.error(t("message.missing_fields_error"));
};

useEffect(() => {
if (block) {
Expand All @@ -110,7 +113,10 @@ export const BlockEditForm: FC<ComponentFormProps<IBlock>> = ({
}, [block, reset]);

return (
<Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
<Wrapper
onSubmit={handleSubmit(onSubmitForm, onSubmitError)}
{...WrapperProps}
>
<BlockFormProvider methods={methods} block={block || undefined}>
<ContentContainer>
<ContentItem display="flex" gap={5}>
Expand Down