-
Notifications
You must be signed in to change notification settings - Fork 126
fix: validation bypass when updating block #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes introduce a new error message key, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BlockEditForm
participant Toast
participant i18n
User->>BlockEditForm: Submit form
alt Validation passes
BlockEditForm->>BlockEditForm: Process submission
else Validation fails
BlockEditForm->>i18n: Get "missing_fields_error" message
i18n-->>BlockEditForm: Localized error string
BlockEditForm->>Toast: Show error notification
end
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
acdb746
to
e30f5ea
Compare
id={`vertical-tabpanel-${index}`} | ||
aria-labelledby={`vertical-tab-${index}`} | ||
sx={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is causing settings to become cropped in UI rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes @MohamedAliBouhaouala true I'll fix this 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation
This PR introduces a validation error message when required fields are missing in the block editing form.
Fixes #933
Type of change:
Please delete options that are not relevant.
Checklist:
Summary by CodeRabbit