Microsoft Mvvm Toolkit support #17
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing] methods in addition to Raise* methods
…mentation is generated in parent class
AlexanderEgorov
suggested changes
Jun 24, 2022
DevExpress.Mvvm.CodeGenerators.Tests/UnitTests/UnitTests.csproj
Outdated
Show resolved
Hide resolved
DevExpress.Mvvm.CodeGenerators.Tests/SharedTests/MvvmToolkit/AttributeTransferTests.cs
Outdated
Show resolved
Hide resolved
DevExpress.Mvvm.CodeGenerators.Tests/SharedTests/MvvmToolkit/NullableAnnotationTests.cs
Outdated
Show resolved
Hide resolved
| .Append('(') | ||
| .Append(propertyName) | ||
| .Append("Chang") | ||
| .Append(suffix) |
There was a problem hiding this comment.
Just a recommendation: Instead of a set of Append calls, make an extension method that accepts 'params string[]'
There was a problem hiding this comment.
"Append" calls are chained to avoid excessive memory traffci and improve performance. Correct approach is to use Interpolated String Handler available in C# 10. Probably somewhere in the future.
AlexanderEgorov
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.